Bugfix: use layout when placing tikz operations for nq gates #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with placing of non-controlled nq (n > 1) gates in the circuit rendering algorithm. The basic problem was that something like "FOO p q r" would have the Tikz operator
\gate[wires=3]{FOO}placed on the qubit line forp, even if that line happened to be below the lines for eitherqorrin the diagram. This is not valid as far as quantikz is concerned. Now we should have the operator placed on whatever qubit line happens to be first, with respect to our layout. Note that this happened to sneak under the radar because the only n > 1 qubit gates I had tested with happened to have special handling (e.g.CNOT).