Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu Redesign #75

Merged
merged 23 commits into from
Aug 14, 2022
Merged

Menu Redesign #75

merged 23 commits into from
Aug 14, 2022

Conversation

CameronRWest
Copy link
Contributor

@CameronRWest CameronRWest commented Jul 21, 2022 •
edited
Loading

Redesigned Menu

Menu.js

  • Created SetActive sub to set the current link's class as active
  • Updated Menu Item classes to have class name rather than individual link
  • Updated NavBar button icon

Menu.scss

  • Redesigned Menu and NavBar look
  • Made MenuBar sticky to top of site
  • Made NavButton appear when site is certain width

Index.js

  • Calling SetActive for init load

General Changes

  • Moved images to assets folder.
  • Changed image urls to include assets folder.

Closes #74, #90

@CameronRWest CameronRWest added documentation 📜 Improvements or additions to documentation enhancement ➕ New feature or request labels Jul 21, 2022
@CameronRWest CameronRWest added this to the v0.2.0 Beta 🥯 milestone Jul 21, 2022
@CameronRWest CameronRWest requested a review from mrharpo July 21, 2022 21:13
@CameronRWest CameronRWest self-assigned this Jul 21, 2022
@CameronRWest CameronRWest linked an issue Jul 21, 2022 that may be closed by this pull request
Menu Redesign #74
Closed
8 tasks
mrharpo
mrharpo approved these changes Jul 31, 2022
View reviewed changes
Copy link
Collaborator

@mrharpo mrharpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great work! The redesign looks nice and fluid. 💧 Thanks for putting the effort into fixing up some older code!

@CameronRWest CameronRWest linked an issue Aug 12, 2022 that may be closed by this pull request
Menu Nav not disappearing when window has been increased #90
Closed
1 task
@mrharpo mrharpo changed the base branch from dev to main August 14, 2022 19:00
@mrharpo mrharpo merged commit 5f1b2b9 into main Aug 14, 2022
@mrharpo mrharpo deleted the menu branch August 14, 2022 21:11
@mrharpo mrharpo mentioned this pull request Aug 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrharpo mrharpo mrharpo approved these changes

@subcontrabass subcontrabass Awaiting requested review from subcontrabass

Assignees

@CameronRWest CameronRWest

Labels
documentation 📜 Improvements or additions to documentation enhancement ➕ New feature or request
Projects
None yet
Milestone
v0.2.0 Beta 🥯
Development

Successfully merging this pull request may close these issues.

Menu Nav not disappearing when window has been increased Menu Redesign
2 participants
@CameronRWest @mrharpo