-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magnussens #42
Merged
Merged
Magnussens #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subcontrabass
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working form for car commercial generation:
Video
- base video - default campaign vs RSGDuration
- duration of final video - 30 / 60Car Name
- with proper font, color, and bezier fly in appliedOffer Info
- formatted with proper font, color, weight, etc.Offer alignment
- left / centerLegal Text
- formatted with proper font, color, weight, etc.Resolution
- selector for resolutionPreview
- show preview on pageRender
- send to render queueOther changes:
api
otto
generateEdl
to standardize edl creation and simplify codebezier2
function (currently only implemented for fly in right)**kwargs
to all templates to allow all parametersrenderMultitrack
emailer
functionality to send emailswebsite
Components.js
- contains stateless components needed to build Magnussens formRenders
- addedissue
button to report issue with video. Popup asks what's wrong, and sends email with provided text... and many more!