Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnussens #42

Merged
merged 40 commits into from
Mar 22, 2021
Merged

Magnussens #42

merged 40 commits into from
Mar 22, 2021

Conversation

mrharpo
Copy link
Collaborator

@mrharpo mrharpo commented Mar 3, 2021

Working form for car commercial generation:

  • Video - base video - default campaign vs RSG
  • Duration - duration of final video - 30 / 60
  • Car Name - with proper font, color, and bezier fly in applied
  • Offer Info - formatted with proper font, color, weight, etc.
  • Offer alignment - left / center
  • Legal Text - formatted with proper font, color, weight, etc.
  • Resolution - selector for resolution
  • Preview - show preview on page
  • Render - send to render queue

Other changes:

api

  • updated otto
    • generateEdl to standardize edl creation and simplify code
    • added bezier2 function (currently only implemented for fly in right)
    • added **kwargs to all templates to allow all parameters
  • breaking change: removed media field from render call
  • render now defaults to using renderMultitrack
  • fixed download function (closes fix api download media #40)
  • simplified docker image creation process
  • added emailer functionality to send emails

website

  • added logo
  • added Components.js - contains stateless components needed to build Magnussens form
  • Renders - added issue button to report issue with video. Popup asks what's wrong, and sends email with provided text

... and many more!

Copy link
Contributor

@subcontrabass subcontrabass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@mrharpo mrharpo merged commit fc97749 into master Mar 22, 2021
@mrharpo mrharpo deleted the magnussens branch June 17, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix api download media
2 participants