Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mongo health checks #45523

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix Mongo health checks #45523

merged 1 commit into from
Jan 13, 2025

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 13, 2025 •
edited
Loading

Prior to this change, the health checks would
erroneously report the connection was up
if the database had yet to be contacted
by the application

@geoand
Fix Mongo health checks
289cf09 
Prior to this change, the health checks would
erroneously report the connection was up
if the database had yet to be contacted
by the application
@geoand geoand requested a review from cescoffier January 13, 2025 09:40
@geoand geoand mentioned this pull request Jan 13, 2025
Closed
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 13, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 289cf09.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 13, 2025
@github-actions GitHub Actions
Copy link

🎊 PR Preview ec6bf3c has been successfully built and deployed to https://quarkus-pr-main-45523-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@geoand geoand merged commit 7e76c74 into quarkusio:main Jan 13, 2025
24 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 13, 2025
@geoand geoand deleted the #45482 branch January 13, 2025 10:13
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 13, 2025
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.7 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/mongodb kind/bugfix triage/backport-3.15
Projects
None yet
Milestone
3.17.7
Development

Successfully merging this pull request may close these issues.

Execute the MongoDB Connection Health Check on Startup
3 participants
@geoand @cescoffier @gsmet