Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in deploying-to-kubernetes.adoc #45419

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

rogerwalt
Copy link
Contributor

No description provided.

Copy link

quarkus-bot bot commented Jan 7, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@gsmet gsmet changed the title fix typo Fix typo in deploying-to-kubernetes.adoc Jan 7, 2025
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to open a PR!

I added some additional suggestions as there are more typos in this sentence.

Could you apply the change and squash? If you don't feel like it, I can do it.

docs/src/main/asciidoc/deploying-to-kubernetes.adoc Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jan 7, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@gsmet gsmet changed the title Fix typo in deploying-to-kubernetes.adoc Fix typos in deploying-to-kubernetes.adoc Jan 7, 2025
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squashed the additional changes, let's wait for CI and merge!

@gsmet gsmet added triage/backport-3.15 triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 7, 2025
Copy link

quarkus-bot bot commented Jan 7, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit c7f68ae.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 9c0b7b3 into quarkusio:main Jan 8, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 8, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 8, 2025
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.7 Jan 14, 2025
@gsmet gsmet modified the milestones: 3.17.7, 3.15.4 Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants