Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matrix computation for Ubuntu 24 #45190

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Dec 18, 2024

@holly-cummins I was able to reproduce your issue and this should fix it.

Copy link

quarkus-bot bot commented Dec 18, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Dec 18, 2024
@gsmet
Copy link
Member Author

gsmet commented Dec 18, 2024

Let's merge it and see how it goes as this thing is not really tested by this CI run.

@gsmet gsmet merged commit 969b378 into quarkusio:main Dec 18, 2024
11 of 49 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 18, 2024
@gsmet
Copy link
Member Author

gsmet commented Dec 18, 2024

@holly-cummins if you can rebase your PR, I would be interested to know the result.

@holly-cummins
Copy link
Contributor

holly-cummins commented Dec 18, 2024

@holly-cummins if you can rebase your PR, I would be interested to know the result.

Confirmed that it's working, and I have JVM tests: /~https://github.com/holly-cummins/quarkus/actions/runs/12398637710

(Don't be confused by the confusing name of the last commit in that CI run. I've also forced some of my native and JVM runners onto ubuntu-22 while waiting for #45160, hence the commit about forcing ubuntu 22. The main matrix calculation is running on 24.)

@gsmet
Copy link
Member Author

gsmet commented Dec 18, 2024

Awesome, thanks for confirming!

@gsmet gsmet modified the milestones: 3.18 - main, 3.17.5 Dec 18, 2024
@gsmet gsmet modified the milestones: 3.17.5, 3.15.4 Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure triage/backport-3.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants