Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce firmware size in prep for #12670 #13724

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Reduce firmware size in prep for #12670 #13724

merged 2 commits into from
Jul 27, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 26, 2021

Description

When #12670 is merged, it will bloat the size of a number of keyboards/keymaps.

This checks for those boards preemptively, and should allow those boards to compile under size.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team July 26, 2021 17:48
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 26, 2021
@drashna drashna force-pushed the fix/keyboard_pixel_size branch from 0143099 to b8196e0 Compare July 26, 2021 18:31
@fauxpark fauxpark mentioned this pull request Jul 26, 2021
Merged
14 tasks
@drashna drashna force-pushed the fix/keyboard_pixel_size branch from b8196e0 to e00741c Compare July 27, 2021 00:49
@drashna drashna changed the title Reduce firmware size in pre for #12670 Reduce firmware size in prep for #12670 Jul 27, 2021
@tzarc tzarc merged commit 3affdcb into qmk:develop Jul 27, 2021
@drashna drashna deleted the fix/keyboard_pixel_size branch July 27, 2021 02:43
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@drashna @nhongooi
Reduce firmware size in prep for qmk#12670 (qmk#13724)
cbb9612 
* Reduce firmware size in pre for qmk#12670

* Also disable pixel mode, just in case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @tzarc @fauxpark