Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples and documentation for QlikView #18

Merged
merged 6 commits into from
Nov 7, 2017
Merged

Examples and documentation for QlikView #18

merged 6 commits into from
Nov 7, 2017

Conversation

joesiltbergqlik
Copy link
Contributor

Fixes QV-12318.

Status

[ ] Under development
[x] Waiting for code review
[ ] Waiting for merge

Information

[ ] Contains breaking changes
[ ] Contains new API(s)
[x] Contains documentation
[ ] Contains test
[x] Contains examples

josefinestal
josefinestal reviewed Nov 6, 2017
View reviewed changes
docs/README.md Outdated

* **New log file**
You will see a new type of log file in the Qlik Sense engine logs containing SSE-specific information.
You will see a new type of log file in the Qlik Sense engine logs and the QlikView Server logs containing SSE-specific information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking if we should provide more information about SSE logs in general, e.g. where to find the specific log files, how to change verbosity etc? Or is it enough to have it as is? Also, there are logs for QlikView Desktop as well. One must enable the ExtendedErrorLoggingMode setting and the information is added to the QlikViewError.log file and not to a separate log file as in the other cases. I know the logs in QlikView are not usually used by the users unless there are any problems, but it might be a good idea to mention in this case? since the development of apps using SSE will be done mainly in Desktop, if I've understood it correctly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be removed from here and only documented on help.qlik.com. It is a Qlik product specific feature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, good point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the section.

@joesiltbergqlik
Remove "New log file" section.
aa3744b 
After PR discussion, to be only documented on help.qlik.com.
@josefinestal
Copy link
Contributor

It looks good, I tested the examples as well and they all work fine. (I can't find the option to approve after I sent the last comment)

tobiaslindulf
tobiaslindulf approved these changes Nov 6, 2017
View reviewed changes
Copy link
Contributor

@tobiaslindulf tobiaslindulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed a small cleanup of limitations and added a planned improvement. To me it looks good now.

@joesiltbergqlik joesiltbergqlik merged commit b6b7f0b into master Nov 7, 2017
@joesiltbergqlik joesiltbergqlik deleted the qvdoc branch November 7, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefinestal josefinestal josefinestal left review comments

@tobiaslindulf tobiaslindulf tobiaslindulf approved these changes

@qlikmats qlikmats Awaiting requested review from qlikmats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joesiltbergqlik @josefinestal @tobiaslindulf