Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve content file/folder names handling #13995

Merged
merged 2 commits into from
Dec 29, 2020

Conversation

glassez
Copy link
Member

@glassez glassez commented Dec 17, 2020

  • Move files/folders renaming functions to core classes.
  • Query file/folder for renaming by its current path.
  • Add ability to rename content folders from WebAPI/WebUI.

Closes #12328.
Supercedes #13081.

@glassez glassez added WebUI WebUI-related issues/changes Core WebAPI WebAPI-related issues/changes labels Dec 17, 2020
@glassez glassez force-pushed the rename-files branch 2 times, most recently from 9fa9da6 to 46d403a Compare December 18, 2020 04:08
@FranciscoPombal

This comment has been minimized.

@glassez

This comment has been minimized.

@FranciscoPombal

This comment has been minimized.

@glassez

This comment has been minimized.

@glassez glassez force-pushed the rename-files branch 4 times, most recently from 91491e1 to c2a78b5 Compare December 18, 2020 12:44
@glassez
Copy link
Member Author

glassez commented Dec 18, 2020

(optional) Handle .!qb extension behind the scenes.

In the end, I decided not to do it here. As it turns out, it requires a lot more modifications than I expected, so I'll put it off for later so as not to delay the rest.

@glassez glassez marked this pull request as ready for review December 18, 2020 12:49
@glassez glassez requested review from Chocobo1 and a team December 18, 2020 12:49
@FranciscoPombal

This comment has been minimized.

@FranciscoPombal
Copy link
Member

@glassez

In the end, I decided not to do it here. As it turns out, it requires a lot more modifications than I expected, so I'll put it off for later so as not to delay the rest.

What were you hoping to fix with that, anyway? What are the "known issues" with .!qB currently observable?

@glassez
Copy link
Member Author

glassez commented Dec 18, 2020

What were you hoping to fix with that, anyway? What are the "known issues" with .!qB currently observable?

I just wanted to make the code more structured. Currently, the .!qb extension handling logic is spread across several layers and components of the application.

@thalieht
Copy link
Contributor

I can't find any problems but my testing wasn't very thorough (just renamed a file, the root folder and tested WebUI).
Btw don't forget to remove "Handle .!qb extension behind the scenes." from the last commit.

@glassez

This comment has been minimized.

It should return empty string if there is no parent folder.
@glassez glassez force-pushed the rename-files branch 2 times, most recently from 0893adb to 7a763c3 Compare December 26, 2020 17:35
@glassez glassez requested a review from Chocobo1 December 28, 2020 05:32
@glassez glassez added this to the 4.3.3 milestone Dec 28, 2020
Move files/folders renaming functions to core classes.
Query file/folder for renaming by its current path.
Add ability to rename content folders from WebAPI/WebUI.
@glassez glassez merged commit 348109a into qbittorrent:master Dec 29, 2020
@glassez glassez deleted the rename-files branch December 29, 2020 19:28
IceCodeNew pushed a commit to IceCodeNew/qBittorrent-Enhanced-Edition that referenced this pull request Dec 30, 2020
Improve content file/folder names handling
@masterwishx
Copy link

Thanks first of all for adding this option.
and sorry for stupid question im new in github, if (Improve content file/folder names handling #13995) merged to master ,
so it will avalibe in next release version ? i need it it for docker - binhex/arch-qbittorrentvpn
Thanks again

@thalieht
Copy link
Contributor

thalieht commented Jan 5, 2021

so it will avalibe in next release version ?

Yes

@masterwishx
Copy link

masterwishx commented Jan 19, 2021

is this option avalible from version 4.3.2 or 4.3.3?

i did not finded in binhex/arch-qbittorrentvpn based on 4.3.2
and i think this option merged in 29.12.20 but i founded that wrote on 4.3.2

( Sunday December 27th 2020 - qBittorrent v4.3.2 release

v4.3.2 changelog:

FEATURE: Allow to add root folder to torrent content (glassez) )

i think its meaned this option ?
so why its not avalible in binhex/arch-qbittorrentvpn based on 4.3.2 ?

or maybe this option in 4.3.3
Thursday January 19th 2021 - qBittorrent v4.3.3 release
qBittorrent v4.3.3 was released.
Support for macOS 10.13 (High Sierra) was dropped because Xcode doesn't support C++17 for that version.
For the same reason it is highly likely that support for Ubuntu 18.04 (Bionic Beaver) will be dropped in the next releases.

v4.3.3 changelog:

WEBUI: Update "Keep top-level folder" in WebUI options (thalieht)

so only now it will be avalible ?

@ArcticGems
Copy link

included in 4.3.3 =
BUGFIX: Improve content file/folder names handling (glassez)

@masterwishx
Copy link

OK thanks

@masterwishx
Copy link

Very happy now , im was waiting for this highly needed option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core WebAPI WebAPI-related issues/changes WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No rename windows for folders in WebUI
6 participants