-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve content file/folder names handling #13995
Conversation
9fa9da6
to
46d403a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
91491e1
to
c2a78b5
Compare
In the end, I decided not to do it here. As it turns out, it requires a lot more modifications than I expected, so I'll put it off for later so as not to delay the rest. |
This comment has been minimized.
This comment has been minimized.
What were you hoping to fix with that, anyway? What are the "known issues" with |
I just wanted to make the code more structured. Currently, the .!qb extension handling logic is spread across several layers and components of the application. |
I can't find any problems but my testing wasn't very thorough (just renamed a file, the root folder and tested WebUI). |
This comment has been minimized.
This comment has been minimized.
c2a78b5
to
7a2bc87
Compare
It should return empty string if there is no parent folder.
0893adb
to
7a763c3
Compare
7a763c3
to
4c0f0c5
Compare
Move files/folders renaming functions to core classes. Query file/folder for renaming by its current path. Add ability to rename content folders from WebAPI/WebUI.
4c0f0c5
to
4453e7f
Compare
Improve content file/folder names handling
Thanks first of all for adding this option. |
Yes |
is this option avalible from version 4.3.2 or 4.3.3? i did not finded in binhex/arch-qbittorrentvpn based on 4.3.2 ( Sunday December 27th 2020 - qBittorrent v4.3.2 release v4.3.2 changelog: FEATURE: Allow to add root folder to torrent content (glassez) ) i think its meaned this option ? or maybe this option in 4.3.3 v4.3.3 changelog: WEBUI: Update "Keep top-level folder" in WebUI options (thalieht) so only now it will be avalible ? |
included in 4.3.3 = |
OK thanks |
Very happy now , im was waiting for this highly needed option |
Closes #12328.
Supercedes #13081.