Add stalled filters to GUI and Web API/UI #11825

FranciscoPombal · 2020-01-04T20:10:54Z

/api/v2/torrents/info can now take the following new values for thefilter parameter: stalled, stalled_uploading and stalled_downloading.

Requires Web API version bump.

Closes #11787

Screenshots:

GUI:

WebUI:

FranciscoPombal · 2020-01-09T13:25:06Z

@glassez @Chocobo1
Can I get a review, please? I am especially unsure about the web API version bump:

Should it be bumped at all, or just lumped in with the v2.4.0 changes?
If it should be bumped, should it be squashed or remain as a separate commit?

Chocobo1 · 2020-01-09T13:36:01Z

Adds the following filters:
stalled
stalled_up
stalled_down

Is it possible to use them in WebUI/GUI?

FranciscoPombal · 2020-01-09T13:40:50Z

Is it currently possible to use them in WebUI/GUI?

Nope, it is not currently possible, and I did not touch the WebUI/GUI code. Should I include that in this PR, or is that content for a separate one?

Chocobo1 · 2020-01-09T17:54:31Z

Should I include that in this PR, or is that content for a separate one?

I think it should be included in this PR. The changes would not be very useful if it cannot be used.

FranciscoPombal · 2020-01-10T19:43:39Z

@Chocobo1

I think it should be included in this PR. The changes would not be very useful if it cannot be used.

Well, the changes are usable via the WebAPI. Still, I agree that all interfaces should benefit from the change, so I now also implemented the filtering on the WebUI and GUI.

Should I keep the WebAPI version bump commit? These changes could be part of the API version 2.4.0 just as well.

src/webui/www/private/scripts/dynamicTable.js

Chocobo1 · 2020-01-11T02:44:54Z

Should I keep the WebAPI version bump commit? These changes could be part of the API version 2.4.0 just as well.

I'm not really sure. I guess the version should bump only if it hasn't been done before.

Chocobo1 · 2020-01-11T02:45:42Z

Let's also not forget ping @Piccirello to review the webUI/webAPI parts.

Piccirello

LGTM

src/webui/www/private/scripts/dynamicTable.js

Piccirello · 2020-01-11T10:39:45Z

The last release used 2.4.0 so we'll have to bump the version for these changes.

It seems we use a modified semantic versioning: the minor version (x.Y.z) is bumped for breaking changes, and the patch version (x.y.Z) is bumped for new features and bug fixes. The last release probably should have used 2.3.1 instead of 2.4.0. Nevertheless, this will be 2.4.1.

glassez · 2020-01-11T11:30:54Z

It seems we use a modified semantic versioning: the minor version (x.Y.z) is bumped for breaking changes, and the patch version (x.y.Z) is bumped for new features and bug fixes.

API versioning has compatibility related semantic: the patch version (x.y.Z) is bumped when we don't break current clients compatibility, and the minor version (x.Y.z) is bumped when we do it. I.e. clients that implement support of API x.y.z remain compatible with all the upcoming API x.y.*.

src/base/bittorrent/torrenthandle.cpp

src/base/bittorrent/torrenthandle.h

src/webui/www/private/scripts/dynamicTable.js

Chocobo1 · 2020-01-13T01:52:13Z

@FranciscoPombal
Can upload a screenshot of the filters in the opening post?

`/api/v2/torrents/info` can now take the following new values for the`filter` parameter: `stalled`, `stalled_uploading` and `stalled_downloading`. Requires Web API version bump. Closes qbittorrent#11787

FranciscoPombal · 2020-01-13T11:51:07Z

@Chocobo1 done.

glassez · 2020-01-14T04:17:36Z

Since entire app are affected you can (should) rename both PR/commit: Add Stalled filters.

Chocobo1

LGTM (for code)

Chocobo1 · 2020-01-14T04:57:47Z

@sledgehammer999
What do you think of this PR? It slightly changes the UI and I would rather wait for your opinion before merging.

ghost · 2020-02-08T05:22:09Z

Instead of saying "stalled", we could use something more descriptive like utorrent does.
"Finding peers" when there's 0 peers and "Connecting to peers" when there's >=1 seeders but you can't connect with them.

FranciscoPombal · 2020-02-08T16:14:29Z

Instead of saying "stalled", we could use something more descriptive like utorrent does.
"Finding peers" when there's 0 peers and "Connecting to peers" when there's >=1 seeders but you can't connect with them.

That sounds like a good idea, but it is a little out of scope for this PR and involves some more thorough changes.

glassez · 2020-02-09T14:41:14Z

"Finding peers" when there's 0 peers and "Connecting to peers" when there's >=1 seeders but you can't connect with them.

I'm not sure it correctly describes what is really happening...

Chocobo1 · 2020-02-14T03:38:03Z

@FranciscoPombal
There is nothing wrong with this PR, just waiting for @sledgehammer999 opinion since the PR added more elements to the UI.

sledgehammer999 · 2020-02-16T16:32:33Z

Thanks.

As suggested in qbittorrent/qBittorrent#11825 (comment)

As suggested in qbittorrent#11825 (comment)

As suggested in #11825 (comment)

FranciscoPombal force-pushed the stalled_filter branch from 2b101ec to d9ba202 Compare January 10, 2020 19:40

FranciscoPombal changed the title ~~Web API: added stalled filters for /api/v2/torrents/info~~ Add stalled filters to GUI and Web API/UI Jan 10, 2020

Chocobo1 reviewed Jan 11, 2020

View reviewed changes

src/webui/www/private/scripts/dynamicTable.js Outdated Show resolved Hide resolved

Piccirello reviewed Jan 11, 2020

View reviewed changes

src/webui/www/private/scripts/dynamicTable.js Outdated Show resolved Hide resolved

glassez reviewed Jan 11, 2020

View reviewed changes

src/base/bittorrent/torrenthandle.cpp Outdated Show resolved Hide resolved

src/base/bittorrent/torrenthandle.h Outdated Show resolved Hide resolved

FranciscoPombal force-pushed the stalled_filter branch 2 times, most recently from df6d8d4 to f0ce709 Compare January 12, 2020 00:42

Chocobo1 reviewed Jan 12, 2020

View reviewed changes

src/webui/www/private/scripts/dynamicTable.js Show resolved Hide resolved

NotTsunami mentioned this pull request Jan 12, 2020

WebUI: Use correct operators in logical expressions #11871

Merged

FranciscoPombal added 2 commits January 13, 2020 11:41

Add stalled filters to GUI and Web API/UI

f4742a9

`/api/v2/torrents/info` can now take the following new values for the`filter` parameter: `stalled`, `stalled_uploading` and `stalled_downloading`. Requires Web API version bump. Closes qbittorrent#11787

Bump Web API version

df2fbb1

FranciscoPombal force-pushed the stalled_filter branch from f0ce709 to df2fbb1 Compare January 13, 2020 11:48

FranciscoPombal requested review from glassez and Chocobo1 January 13, 2020 11:51

Chocobo1 approved these changes Jan 14, 2020

View reviewed changes

FranciscoPombal mentioned this pull request Jan 14, 2020

Add piece_extent_affinity to AdvancedSettings #11781

Merged

FranciscoPombal requested review from Chocobo1 and Piccirello February 13, 2020 16:53

sledgehammer999 merged commit 322ae3e into qbittorrent:master Feb 16, 2020

FranciscoPombal deleted the stalled_filter branch February 16, 2020 17:57

zeule pushed a commit to zeule/qbit that referenced this pull request Feb 28, 2020

WebUI: Use correct operators in logical expressions

cec5af4

As suggested in qbittorrent/qBittorrent#11825 (comment)

sledgehammer999 pushed a commit to sledgehammer999/qBittorrent that referenced this pull request Mar 21, 2020

WebUI: Use correct operators in logical expressions

5af14ab

As suggested in qbittorrent#11825 (comment)

sledgehammer999 pushed a commit that referenced this pull request Mar 24, 2020

WebUI: Use correct operators in logical expressions

7444227

As suggested in #11825 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add stalled filters to GUI and Web API/UI #11825

Add stalled filters to GUI and Web API/UI #11825

FranciscoPombal commented Jan 4, 2020 •

edited

Loading

FranciscoPombal commented Jan 9, 2020

Chocobo1 commented Jan 9, 2020 •

edited

Loading

FranciscoPombal commented Jan 9, 2020

Chocobo1 commented Jan 9, 2020

FranciscoPombal commented Jan 10, 2020

Chocobo1 commented Jan 11, 2020

Chocobo1 commented Jan 11, 2020

Piccirello left a comment

Piccirello commented Jan 11, 2020 •

edited

Loading

glassez commented Jan 11, 2020

Chocobo1 commented Jan 13, 2020

FranciscoPombal commented Jan 13, 2020

glassez commented Jan 14, 2020

Chocobo1 left a comment •

edited

Loading

Chocobo1 commented Jan 14, 2020

ghost commented Feb 8, 2020 •

edited by ghost

Loading

FranciscoPombal commented Feb 8, 2020

glassez commented Feb 9, 2020

Chocobo1 commented Feb 14, 2020

sledgehammer999 commented Feb 16, 2020

Add stalled filters to GUI and Web API/UI #11825

Add stalled filters to GUI and Web API/UI #11825

Conversation

FranciscoPombal commented Jan 4, 2020 • edited Loading

FranciscoPombal commented Jan 9, 2020

Chocobo1 commented Jan 9, 2020 • edited Loading

FranciscoPombal commented Jan 9, 2020

Chocobo1 commented Jan 9, 2020

FranciscoPombal commented Jan 10, 2020

Chocobo1 commented Jan 11, 2020

Chocobo1 commented Jan 11, 2020

Piccirello left a comment

Choose a reason for hiding this comment

Piccirello commented Jan 11, 2020 • edited Loading

glassez commented Jan 11, 2020

Chocobo1 commented Jan 13, 2020

FranciscoPombal commented Jan 13, 2020

glassez commented Jan 14, 2020

Chocobo1 left a comment • edited Loading

Choose a reason for hiding this comment

Chocobo1 commented Jan 14, 2020

ghost commented Feb 8, 2020 • edited by ghost Loading

FranciscoPombal commented Feb 8, 2020

glassez commented Feb 9, 2020

Chocobo1 commented Feb 14, 2020

sledgehammer999 commented Feb 16, 2020

FranciscoPombal commented Jan 4, 2020 •

edited

Loading

Chocobo1 commented Jan 9, 2020 •

edited

Loading

Piccirello commented Jan 11, 2020 •

edited

Loading

Chocobo1 left a comment •

edited

Loading

ghost commented Feb 8, 2020 •

edited by ghost

Loading