-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JMA HRIT readers for MTSAT-1R/2 #524
Conversation
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
==========================================
+ Coverage 74.62% 74.81% +0.19%
==========================================
Files 136 136
Lines 18342 18482 +140
==========================================
+ Hits 13687 13827 +140
Misses 4655 4655
Continue to review full report at Codecov.
|
@djhoese Ready to merge as far as I'm concerned. Do you know what's wrong with the AppVeyor build? |
Ah no, we wanted to wait for JMA's feedback regarding Himawari-9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sfinkens Yes, I do. I actually spent my weekend trying to figure out what to do with the appveyor tests. You can see the results in this issue and the ones linked to it: conda-forge/gdal-feedstock#241 Bottom line, we have to wait for a new build of gdal and possibly the geotiff library before things will start working. Hopefully if some of the core conda-forge folks have time today we'll see new builds today or tomorrow (USA/Brazil time zones). Also keep in mind based on #527 that these reader names will likely change in before the SatPy 0.11 release. If this is a problem let's discuss it on slack and find a reasonable solution. |
so it will become |
I think |
Since underscores separate the fields I would prefer |
- Add YAML definitions for MTSAT-1R/2 - Update YAML definition for Himawari-8 - Rename hrit_jma.yaml -> hrit_ahi.yaml - Remove radiance datasets because it is not supported - Add counts datasets - Modify existing JMA HRIT reader: - Add support for half disk scans - Extract platform name from the file (needs to be improved for Himawari-9) - Mask space pixels
c464ea9
to
19a304c
Compare
Regarding the TODOs in the code: I will check that as soon as I have feedback from JMA and have the whole dataset. |
Add method to compute geostationary earth mask
Add JMA HRIT readers for MTSAT-1R/2
Himawari-9)
Tests added
Tests passed
Passes
git diff origin/master -- "*py" | flake8 --diff
Fully documented
Add example notebook