Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of area creation in the grib reader #484

Merged
merged 2 commits into from
Nov 2, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Nov 1, 2018

Turns out sometimes grib files have their data flipped. This now catches that.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

@djhoese djhoese self-assigned this Nov 1, 2018
satpy/readers/grib.py Outdated Show resolved Hide resolved
satpy/readers/grib.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 73.933% when pulling c404a93 on djhoese:bugfix-grib-areas into 8667ef9 on pytroll:master.

@codecov
Copy link

codecov bot commented Nov 1, 2018

Codecov Report

Merging #484 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
- Coverage   73.94%   73.93%   -0.01%     
==========================================
  Files         137      137              
  Lines       18217    18222       +5     
==========================================
+ Hits        13470    13472       +2     
- Misses       4747     4750       +3
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_grib.py 95.83% <100%> (+0.08%) ⬆️
satpy/readers/grib.py 80.14% <70%> (-1.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8667ef9...c404a93. Read the comment docs.

@djhoese djhoese merged commit 5dd28ea into pytroll:master Nov 2, 2018
@djhoese djhoese deleted the bugfix-grib-areas branch November 2, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants