Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ancillary variable loading when anc var is already loaded #341

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jun 28, 2018

In a previous PR I broke ancillary variable loading if the anc var is loaded multiple times. This PR fixes that as well as makes it "illegal" to request a key from a DatasetDict that isn't a str, number, or DatasetID.

  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@coveralls
Copy link

coveralls commented Jun 28, 2018

Coverage Status

Coverage increased (+0.002%) to 69.129% when pulling e652d18 on djhoese:bugfix-anc-vars into a1ce978 on pytroll:master.

@codecov
Copy link

codecov bot commented Jun 28, 2018

Codecov Report

Merging #341 into master will increase coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   69.12%   69.12%   +<.01%     
==========================================
  Files         123      123              
  Lines       15632    15636       +4     
==========================================
+ Hits        10806    10809       +3     
- Misses       4826     4827       +1
Impacted Files Coverage Δ
satpy/readers/yaml_reader.py 85.31% <100%> (+0.06%) ⬆️
satpy/readers/__init__.py 94.81% <50%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ce978...e652d18. Read the comment docs.

@djhoese djhoese merged commit 9767550 into pytroll:master Jun 28, 2018
@djhoese djhoese deleted the bugfix-anc-vars branch June 28, 2018 14:58
@djhoese djhoese self-assigned this Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants