-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix types to allow float32 computations for SAR-C #2925
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2925 +/- ##
==========================================
+ Coverage 96.05% 96.08% +0.03%
==========================================
Files 375 375
Lines 54607 54615 +8
==========================================
+ Hits 52451 52478 +27
+ Misses 2156 2137 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11380299578Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, again just one suggestion inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't mind some dtype
before and after dask compuation, but otherwise looks good. Not a show stopping request. Merge if you disagree. Example:
data_arr_dask = filehandler.get_dataset(...)
data_arr_np = data_arr_dask.compute()
assert data_arr_np.dtype == np.float32
assert data_arr_np.dtype == data_arr_dask.dtype
Co-authored-by: Panu Lahtinen <pnuu+git@iki.fi>
You mentioned this in another pr already, and I basically agree. It's just that I forget about it. I'll fix it soon. |
This PR fixes type to makes sure the sensor data is kept in float32s.
It also add the
get_bounding_box
method and puts it as an attribute in the SwathDefinition.AUTHORS.md
if not there already