Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support FIRG file-patterns coming from EUMETCast-Europe #2882

Merged

Conversation

fwfichtner
Copy link
Contributor

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (6860030) to head (abe48ae).
Report is 382 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2882      +/-   ##
==========================================
- Coverage   95.99%   95.97%   -0.02%     
==========================================
  Files         368      368              
  Lines       53985    53973      -12     
==========================================
- Hits        51821    51801      -20     
- Misses       2164     2172       +8     
Flag Coverage Δ
behaviourtests 4.02% <ø> (+<0.01%) ⬆️
unittests 96.07% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10365306296

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 96.073%

Files with Coverage Reduction New Missed Lines %
satpy/tests/utils.py 2 93.16%
satpy/tests/reader_tests/gms/test_gms5_vissr_l1b.py 3 98.67%
satpy/tests/reader_tests/gms/test_gms5_vissr_navigation.py 3 97.18%
Totals Coverage Status
Change from base Build 10303695673: -0.01%
Covered Lines: 52030
Relevant Lines: 54157

💛 - Coveralls

@fwfichtner fwfichtner marked this pull request as ready for review August 13, 2024 10:58
@ameraner ameraner added enhancement code enhancements, features, improvements component:readers labels Aug 13, 2024
@ameraner
Copy link
Member

LGTM, thanks for adding the path, good to see that it was the only thing needed to support the files!

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 89f09d3 into pytroll:main Aug 14, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seviri_l2_grib-reader support for filename patterns of files coming from EUMETCast-Europe
4 participants