Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test skips when numba is involved in the unstable CI #2844

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jun 28, 2024

It looks like hvplot now depends on numba and is causing failures in unstable CI. We typically skip these types of failures.

  • Closes #xxxx
  • Tests added
  • Fully documented

@djhoese djhoese added the cleanup Code cleanup but otherwise no change in functionality label Jun 28, 2024
@djhoese djhoese requested a review from mraspaud as a code owner June 28, 2024 16:59
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (fc95ee1) to head (2c18e63).
Report is 334 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2844      +/-   ##
==========================================
+ Coverage   95.94%   95.96%   +0.02%     
==========================================
  Files         366      366              
  Lines       53584    53592       +8     
==========================================
+ Hits        51412    51431      +19     
+ Misses       2172     2161      -11     
Flag Coverage Δ
behaviourtests 4.04% <9.52%> (+<0.01%) ⬆️
unittests 96.06% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9716294452

Details

  • 15 of 17 (88.24%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 96.052%

Changes Missing Coverage Covered Lines Changed/Added Lines %
satpy/tests/utils.py 5 7 71.43%
Totals Coverage Status
Change from base Build 9702977764: 0.006%
Covered Lines: 51650
Relevant Lines: 53773

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9716691189

Details

  • 15 of 17 (88.24%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 96.052%

Changes Missing Coverage Covered Lines Changed/Added Lines %
satpy/tests/utils.py 5 7 71.43%
Totals Coverage Status
Change from base Build 9702977764: 0.006%
Covered Lines: 51650
Relevant Lines: 53773

💛 - Coveralls

@djhoese djhoese closed this Jun 28, 2024
@djhoese djhoese reopened this Jun 28, 2024
@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9718428391

Details

  • 16 of 18 (88.89%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 96.052%

Changes Missing Coverage Covered Lines Changed/Added Lines %
satpy/tests/utils.py 5 7 71.43%
Totals Coverage Status
Change from base Build 9702977764: 0.006%
Covered Lines: 51650
Relevant Lines: 53773

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 29, 2024

Pull Request Test Coverage Report for Build 9720667119

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 96.067%

Totals Coverage Status
Change from base Build 9702977764: 0.02%
Covered Lines: 51660
Relevant Lines: 53775

💛 - Coveralls

@djhoese djhoese merged commit 65d28f3 into pytroll:main Jul 2, 2024
19 checks passed
@djhoese djhoese deleted the ci-more-numba-skips branch July 2, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup but otherwise no change in functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants