-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gcps type for newer rioxarray versions #2837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2837 +/- ##
==========================================
- Coverage 95.78% 95.78% -0.01%
==========================================
Files 366 366
Lines 53521 53507 -14
==========================================
- Hits 51267 51252 -15
- Misses 2254 2255 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is marked as enhancement, should it be bug fix? It is a "compatibility" fix technically right?
I was seeing it as an enhancement as it is not a bug in satpy... but I'm not picky, bug works if you prefer it. |
Yeah it could be seen either way. I guess it depends what you want it released as. |
This PR introduces a fix for the backwards incompatibility introduced in corteva/rioxarray#787, and thus should make the tests for SAR pass again.