Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcps type for newer rioxarray versions #2837

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

mraspaud
Copy link
Member

This PR introduces a fix for the backwards incompatibility introduced in corteva/rioxarray#787, and thus should make the tests for SAR pass again.

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Jun 25, 2024
@mraspaud mraspaud self-assigned this Jun 25, 2024
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.78%. Comparing base (2bd607a) to head (ad353f0).
Report is 349 commits behind head on main.

Files with missing lines Patch % Lines
satpy/readers/sar_c_safe.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2837      +/-   ##
==========================================
- Coverage   95.78%   95.78%   -0.01%     
==========================================
  Files         366      366              
  Lines       53521    53507      -14     
==========================================
- Hits        51267    51252      -15     
- Misses       2254     2255       +1     
Flag Coverage Δ
behaviourtests 4.04% <0.00%> (-0.01%) ⬇️
unittests 95.88% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is marked as enhancement, should it be bug fix? It is a "compatibility" fix technically right?

@mraspaud
Copy link
Member Author

This is marked as enhancement, should it be bug fix? It is a "compatibility" fix technically right?

I was seeing it as an enhancement as it is not a bug in satpy... but I'm not picky, bug works if you prefer it.

@djhoese
Copy link
Member

djhoese commented Jun 25, 2024

Yeah it could be seen either way. I guess it depends what you want it released as.

@djhoese djhoese merged commit 5c80fa6 into pytroll:main Jun 26, 2024
7 of 19 checks passed
@mraspaud mraspaud deleted the fix-sar-for-new-rioxarray branch June 26, 2024 08:42
ameraner added a commit to ameraner/satpy that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants