-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to clip AMI negative radiances #2806
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2806 +/- ##
==========================================
- Coverage 95.96% 95.96% -0.01%
==========================================
Files 366 366
Lines 53593 53764 +171
==========================================
+ Hits 51433 51597 +164
- Misses 2160 2167 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 10012906724Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this. I just have some concerns about how information is stored/kept/used.
Ok @simonrp84 I've refactored the tests and hopefully they are easier to follow now BUT while doing this I noticed that the IR clipping tests actually use the fake visible data including the visible metadata. Any issue with me changing this to use the fake IR data? |
OK, thanks for your help on this Dave - really appreciate it. I tested your changes and they work nicely for me so I'm happy that it can be merged. In the process of testing, though, I discovered that the AMI reader is broken with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I did a little more cleanup, but now I'll merge this when CI passes. |
This PR adds the ability to clip negative radiances from AMI datasets. It uses the same method already in place for GOES/ABI and, like ABI, this clipping is disabled by default.