-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new (Eumetrain) FCI RGB composites #2780
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2780 +/- ##
==========================================
- Coverage 95.92% 95.90% -0.03%
==========================================
Files 377 377
Lines 53535 53535
==========================================
- Hits 51356 51345 -11
- Misses 2179 2190 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for adding these! Just a note for now: The example image for the day/night blend with night lights background has the wrong name in the caption I think. |
Pull Request Test Coverage Report for Build 8691804714Details
💛 - Coveralls |
Ah, indeed, thanks for noticing - our plotting tool uses the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for adding all these composites!
This PR adds a series of RGB composites for FCI. In most cases, the new RGBs reuse existing recipes, and will have to be tuned further to account for the specific FCI properties (SRF, resolution, etc).
It adds the composites:
night_ir105
for a simple nighttime layer to be used to fill the night-time part in day-only RGBs (see below). This was used for the EUMETSAT FCI first image and commissioning publications.night_ir_alpha
, as well as the accordingnight_ir_with_background
andnight_ir_with_background_hires
, as known from e.g. SEVIRItrue_color_with_night_ir105
,true_color_with_night_ir
,true_color_with_night_ir_hires
, combining True Color with the night layers abovecloud_type
,cloud_phase
and for each a day-night combination usingnight_ir105
(cloud_*_with_night_ir105
)ir_sandwich
, based oncolorized_ir_clouds
, as well as the day-night combinationir_sandwich_with_night_colorized_ir_clouds
. Uses the same recipe as in SEVIRI, with the spectral colormap.fire_temperature
, with the classic recipe, plus the variants_38refl
with the reflective part of the 3.8µm channel and_rad
with the channels in radiance units (here, the stretch limits have been computed by converting the radiance unit of the existing recipe limits)snow
, since the according composite invisir.yaml
is not being picked up due to the VIS0.8 channel starting only at 0.815, while the dependency looks for 0.824h_microphysics
, which was missing completely in satpy, and is hence added tovisir.yaml
, using the standard EUM recipe from https://resources.eumetrain.org/RGBguide/recipes/RGB_recipes.pdfBy doing this, it contributes in several ways to #2670. To close that issue, we still need to sort out a few midlatitude/tropical recipes: since this affects many shared recipes and is not specific to FCI, I would leave that to a different PR.
After this PR, the list of available composites for FCI becomes:
A gallery of the new RGBs:
cloud_phase
cloud_phase_with_night_ir105
cloud_type
cloud_type_with_night_ir105
true_color_with_night_ir105
true_color_with_night_ir
ir_sandwich
colorized_ir_clouds
ir_sandwich_with_night_colorized_ir_clouds
fire_temperature
fire_temperature_38refl
fire_temperature_rad
snow
24h_microphysics