-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to choose start time to MSI SAFE reader #2776
Conversation
…esently supported. Also, add an option to enable the user to select the observation time based on tile metadata rather than filename, which will prevent one tile from overwriting another when saving multiple tiles individually.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2776 +/- ##
==========================================
- Coverage 95.95% 94.57% -1.38%
==========================================
Files 379 379
Lines 53861 53876 +15
==========================================
- Hits 51680 50952 -728
- Misses 2181 2924 +743
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 9020466876Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding this functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Currently, the
msi_safe
reader uses thefilename_info
to get thestart_time
for a Scene. This can be problematic as multiple tiles can have the samestart_time
and will hence overwrite each other:The user would expect that two images are produced from this, one from each set of files. However, in many cases the second tile will overwrite the image saved by the first.
This PR attempts to fix the problem by allowing an optional
reader_kwarg
that allows the user to specify that thestart_time
should be read from the tile metadata rather than the filename:This will generate two output images as expected.