Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cutoffs for night_ir_alpha and bump up trollimage version #2744

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

mraspaud
Copy link
Member

This PR fixes the satpy configuration for the night ir enhancement for the problem that was reported in pytroll/trollimage#162

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Feb 15, 2024
@mraspaud mraspaud self-assigned this Feb 15, 2024
@mraspaud mraspaud requested review from djhoese and removed request for djhoese February 15, 2024 12:10
@mraspaud
Copy link
Member Author

@TheMetMan you'll be interested in this.

@TheMetMan
Copy link

@mraspaud thanks for the Heads Up.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new version of pyresample should be out and fixes the issue this CI was seeing.

We'll have to make sure the conda-forge recipe is updated with this trollimage limit when we do the next release.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8937d4) 95.89% compared to head (205d5e8) 95.89%.
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2744   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files         371      371           
  Lines       52825    52825           
=======================================
  Hits        50656    50656           
  Misses       2169     2169           
Flag Coverage Δ
behaviourtests 4.15% <ø> (ø)
unittests 95.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mraspaud mraspaud merged commit 754e706 into pytroll:main Feb 16, 2024
18 of 19 checks passed
@mraspaud mraspaud deleted the fix-alpha-stretching-night-ir branch February 16, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants