-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Scene.to_hvplot internals to _scene_converters #2699
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2699 +/- ##
==========================================
- Coverage 95.39% 95.39% -0.01%
==========================================
Files 371 371
Lines 52704 52690 -14
==========================================
- Hits 50277 50263 -14
Misses 2427 2427
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 7247648596
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll let @djhoese merge as he ask for this refactoring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for doing this. As mentioned on slack the readthedocs failure is unrelated to your changes. I think I'll merge this PR and make a separate PR for the fixes. Thanks again.
As requested in PR #2106, the to_hvplot and to_geoviews methods are moved under _scene_converters.py