-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match all projectables in NDVIHybridGreen.__call__
to avoid coordinate mismatch errors
#2694
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2694 +/- ##
==========================================
- Coverage 95.39% 95.37% -0.02%
==========================================
Files 371 371
Lines 52697 52704 +7
==========================================
- Hits 50268 50266 -2
- Misses 2429 2438 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 7224878360
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR, in combination with #2690, fixes #2668.
In the previous implementation, inside the
NDVIHybridGreen
compositor, only the projectables related to the NDVI were being matched. The resulting NDVI fraction was then being combined with the remaining projectable in the super__call__
, which resulted in failures due to mismatching coordinates.This PR fixes this bug by matching all arrays.