-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix automatic reader table not listing readers with missing dependencies #2191
Conversation
@BENR0 don't worry about the linting error, I have fixed it in my PR, which I will merge as soon as the tests pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix, any chance of adding a test?
Codecov Report
@@ Coverage Diff @@
## main #2191 +/- ##
==========================================
+ Coverage 94.03% 94.04% +0.01%
==========================================
Files 289 289
Lines 44564 44617 +53
==========================================
+ Hits 41904 41960 +56
+ Misses 2660 2657 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
So what's left on this? I think @mraspaud was hoping for some type of test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small request
This makes a minor modification to the
available_readers
function to be able to pass a yaml loader type.Based on this for reader table generation when
BasicLoader
is passed reader classes are not instantiated and thus readers with missing dependencies in the RTD build environment are now included in the reader table.