Fix compatibility with pyproj 2.4.2 and reduce generated warnings #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraspaud
requested changes
Dec 6, 2019
mraspaud
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyproj 2.4.2+ returns
inffor invalid values instead of 1e30. Some of pycoast was checking for 1e30 specifically and ended up drawing things incorrectly. I also noticed some warnings where we were using an AreaDefinition's.proj_strattribute. PROJ (the C library) has or is deprecating PROJ.4 strings and pyproj now produces warnings if you convert CRS information to a PROJ.4 representation. I've fixed this by using the AreaDefinition'scrsattribute if possible.Tests were failing without any changes so I figured additional tests weren't needed.
git diff origin/develop **/*py | flake8 --diff