Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary casting in adding overlay from dictionary #38

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Remove unnecessary casting in adding overlay from dictionary #38

merged 2 commits into from
Dec 6, 2019

Conversation

mraspaud
Copy link
Member

  • Tests added
  • Tests passed
  • Passes git diff origin/develop **/*py | flake8 --diff

@mraspaud mraspaud requested a review from adybbroe November 11, 2019 09:25
adybbroe
adybbroe approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@adybbroe adybbroe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine as far as I can see. But one test is failing... ?

@mraspaud
Copy link
Member Author

That should fix it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 86.464% when pulling 36ae7c6 on mraspaud:fix-level-list into abf4995 on pytroll:master.

@djhoese djhoese self-assigned this Dec 6, 2019
@djhoese djhoese added the bug label Dec 6, 2019
@djhoese djhoese merged commit eb35e25 into pytroll:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adybbroe adybbroe adybbroe approved these changes

Assignees

@djhoese djhoese

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mraspaud @coveralls @adybbroe @djhoese