Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coordinate grid overlaying from configuration file #25

Merged
merged 7 commits into from
Oct 17, 2019

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Jan 17, 2019

There is an ancient branch in pytroll/pycoast for adding coordinate grid via config file that was never merged. This PR adds the feature to the updated file structure of pycoast.

  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff
  • Fully documented

@pnuu pnuu self-assigned this Jan 17, 2019
@coveralls
Copy link

coveralls commented Jan 17, 2019

Coverage Status

Coverage increased (+3.6%) to 83.457% when pulling 07439a7 on pnuu:feature-add-grid-from-config into 9b3e5a9 on pytroll:master.

@pnuu
Copy link
Member Author

pnuu commented Feb 1, 2019

The failing OSX tests are apparently caused by a bug in pykdtree. The fix (storpipfugl/pykdtree#43) has been merged but not released in PyPi causing the pip installation to fail.

@djhoese
Copy link
Member

djhoese commented Feb 1, 2019

@pnuu just specify pykdtree and/or pyresample in the conda dependencies.

@pnuu
Copy link
Member Author

pnuu commented Feb 1, 2019

Ah. It was obviously defined in .travis.yaml, I just checked the setup.py file. Lets see what happens.

@mraspaud mraspaud merged commit ced902e into pytroll:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants