Refactor config default search path retrieval #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of dask/dask#8573 to donfig.
Authored by @jrbourbeau in the original dask PR. This removes a long deprecated path from the search list. A lot of the additional refactoring done by James in his PR is not needed here as donfig is already required to use a separate Config object for each new instance. So for this PR's tests the
Config.paths
property is considered public while it may not be considered that in dask. Lastly, I did not include James' last test:as I'm not sure how I would structure donfig to do this. I could extract the path logic to another function, but it would depend on name of the config and the environment variable. At this time this logic is a little too interconnected. For now I'm leaving it.