-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[float8] add float8 training benchmarking scripts #1802
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1802
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 51a9780 with merge base 890e0ac ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
d63c7fa
to
009b331
Compare
@@ -0,0 +1,18 @@ | |||
# Float8 training benchmarking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: move this to benchmarks/float8/something
?
|
||
# validate recipe name | ||
if [ -n "${FLOAT8_RECIPE}" ]; then | ||
if [ "$FLOAT8_RECIPE" != "rowwise" ] && [ "$FLOAT8_RECIPE" != "tensorwise" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this is already checked twice (once in torchtitan, once in Float8LinearConfig), IMO we don't need to check it a third time :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! Let's just move to benchmarks/float8
Looks like test failure is due to #1799 and unrelated to this change. Going to merge |
Summary
Usage
Example