add a deprecation warning for float8 delayed and static scaling #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
vkuzo
added a commit
that referenced
this pull request
Feb 6, 2025
Summary: As titled, the complexity tax for these features is high and there no known real use cases, as the community is overwhelmingly using dynamic scaling. So, IMO we should deprecate this. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 2fc91dbf0556728475624bb70f51553d3fa7042b ghstack-comment-id: 2641358141 Pull Request resolved: #1681
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1681
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3e37558 with merge base 8afd10e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
drisspg
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As titled, the complexity tax for these features is high and there no
known real use cases, as the community is overwhelmingly using dynamic
scaling. So, IMO we should deprecate this.
Test Plan: CI
Reviewers:
Subscribers:
Tasks:
Tags: