-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split contributor guide into quantization overview #1618
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1618
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 117acde with merge base 2aed684 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
e3a0dc0
to
368ffc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Note: We can also rely on torch.compile to generate kernels (through triton), for example the current int8 weight only quantization `kernel </~https://github.com/pytorch/ao/blob/e283743b3cc4612bb641b88dca3670231724d396/torchao/dtypes/affine_quantized_tensor.py#L1292-L1309>`__ just relies on torch.compile to get speedup. In this case there is no specific "efficient kernel" that's corresponding to the type of quantization. | ||
|
||
Quantized Tensors (derived dtypes) | ||
General Guide on Extending torchao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also link to quantization overview to help with context I think
There's a lot of content in the contributor guide that belongs better to "Quantization Overview", so here we split the content and put them in the right pages.
368ffc2
to
117acde
Compare
There's a lot of content in the contributor guide that belongs better to "Quantization Overview", so here we split the content and put them in the right pages.