Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split contributor guide into quantization overview #1618

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

andrewor14
Copy link
Contributor

There's a lot of content in the contributor guide that belongs better to "Quantization Overview", so here we split the content and put them in the right pages.

Copy link

pytorch-bot bot commented Jan 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1618

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 117acde with merge base 2aed684 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 24, 2025
@andrewor14 andrewor14 requested a review from jainapurva January 24, 2025 20:18
@andrewor14 andrewor14 added the topic: documentation Use this tag if this PR adds or improves documentation label Jan 24, 2025
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Note: We can also rely on torch.compile to generate kernels (through triton), for example the current int8 weight only quantization `kernel </~https://github.com/pytorch/ao/blob/e283743b3cc4612bb641b88dca3670231724d396/torchao/dtypes/affine_quantized_tensor.py#L1292-L1309>`__ just relies on torch.compile to get speedup. In this case there is no specific "efficient kernel" that's corresponding to the type of quantization.

Quantized Tensors (derived dtypes)
General Guide on Extending torchao
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also link to quantization overview to help with context I think

There's a lot of content in the contributor guide that belongs
better to "Quantization Overview", so here we split the content
and put them in the right pages.
@andrewor14 andrewor14 merged commit aa0b7ca into main Jan 29, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: documentation Use this tag if this PR adds or improves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants