Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-64921: Clarify wording for open()'s newline arg #96171

Merged
merged 1 commit into from
Oct 7, 2022
Merged

gh-64921: Clarify wording for open()'s newline arg #96171

merged 1 commit into from
Oct 7, 2022

Conversation

slateny
Copy link
Contributor

@slateny slateny commented Aug 22, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 22, 2022
@nanjekyejoannah
Copy link
Contributor

nanjekyejoannah commented Oct 5, 2022 •
edited
Loading

Do you want to take care of the deprecation warning wording too? As suggested by Thomas

@slateny
Copy link
Contributor Author

slateny commented Oct 6, 2022

The PR linked in the description should have taken care of it, but doesn't look like it's there anymore. I'll need to dig up some history and see where/why it might have been removed.

@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 7, 2022
@JelleZijlstra JelleZijlstra merged commit 4a74e6a into python:main Oct 7, 2022
@miss-islington
Copy link
Contributor

Thanks @slateny for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-98041 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
@slateny @miss-islington
pythongh-64921: Clarify wording for open()'s newline arg (pythonGH-96171
62cb023 
)

(cherry picked from commit 4a74e6a)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 7, 2022
@bedevere-bot
Copy link

GH-98042 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
@slateny @miss-islington
pythongh-64921: Clarify wording for open()'s newline arg (pythonGH-96171
b5429d0 
)

(cherry picked from commit 4a74e6a)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 7, 2022
@miss-islington @slateny
gh-64921: Clarify wording for open()'s newline arg (GH-96171)
3dc8eb4 
(cherry picked from commit 4a74e6a)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 7, 2022
@miss-islington @slateny
gh-64921: Clarify wording for open()'s newline arg (GH-96171)
5054ae2 
(cherry picked from commit 4a74e6a)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
@nanjekyejoannah
Copy link
Contributor

I know this is merged but I hope we don't close the issue until we have confirmed on deprecation. Its good to take into consideration some feedback from the issue discussion.

@JelleZijlstra
Copy link
Member

The deprecation is no longer relevant, U was removed in 3.11.

@slateny slateny deleted the s/64921 branch October 8, 2022 15:28
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@slateny @mpage
pythongh-64921: Clarify wording for open()'s newline arg (python#96171)
e7d9ea0
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington @slateny @pablogsal
gh-64921: Clarify wording for open()'s newline arg (GH-96171)
40527c2 
(cherry picked from commit 4a74e6a)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@slateny @nanjekyejoannah @miss-islington @bedevere-bot @JelleZijlstra