-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-99032: datetime docs: Encoding is no longer relevant #93365
Conversation
The `.strftime()` methods return a Unicode string as of Python 3.0.
Could you create a ticket to describe the issue and make it easier to track the fixes? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, maybe we need an issue to track this.
@merwok @nanjekyejoannah I could open an issue, sure, I'm just not sure what to say beyond what I've written here. Maybe,
Actually, now that I think about it again, maybe it'd be better to change the warning from "may contain Unicode characters encoded ..." to "may contain non-ASCII characters." Say the word and I'll open an issue so we can discuss that. |
That’s just the process we follow to keep things manageable 🙂 Full details here: https://devguide.python.org/triage/issue-tracker/ |
Thanks for the PR. I think you will need to include the issue number in your PR title :) |
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GH-103788 is a backport of this pull request to the 3.11 branch. |
The
.strftime()
methods return a Unicode string as of Python 3.0.For reference, under the hood, the
.strftime()
methods usetime.strftime()
, whose return value is defined here for the current tip of the main branch and here for 3.0.Please check my work before merging to make sure I've understood what the docs are saying. I'm also not super familiar with C or RST, but I'm quite sure I've understood them correctly.
Backports should be made to all current versions.
BTW, encoding isn't mentioned in the
time
docs, so no changes required there I don't think.