Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43869: Improve epoch docs #25777

Merged
merged 1 commit into from
Jan 18, 2022
Merged

bpo-43869: Improve epoch docs #25777

merged 1 commit into from
Jan 18, 2022

Conversation

miguendes
Copy link
Contributor

@miguendes miguendes commented May 1, 2021

@miguendes miguendes requested review from abalkin and pganssle as code owners May 1, 2021 10:51
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 1, 2021
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 14, 2021
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as @vstinner wrote in https://bugs.python.org/issue43869#msg391216:

time.time doc says "On Windows and most Unix systems, the epoch is January 1, 1970, 00:00:00 (UTC)"

The epoch doc says "For Unix, the epoch is January 1, 1970, 00:00:00 (UTC)".

At least, the epoch doc can be completed to also mention that it's the same on Windows.

@vstinner
Copy link
Member

Right, it's consistent with: https://docs.python.org/dev/library/time.html#time.time

"On Windows and most Unix systems, the epoch is January 1, 1970, 00:00:00 (UTC) and leap seconds are not counted towards the time in seconds since the epoch."

@vstinner vstinner closed this Jan 18, 2022
@vstinner vstinner reopened this Jan 18, 2022
@vstinner
Copy link
Member

The CI failed. I closed/reopend the CI to trigger new CI jobs. Well, it's an old PR, maybe it contains outside CI config. We will see how it goes ;-)

@vstinner vstinner merged commit ff7703c into python:main Jan 18, 2022
@vstinner
Copy link
Member

Please have a look at my follow-up PR #30664.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants