-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-43869: Improve epoch docs #25777
Conversation
This PR is stale because it has been open for 30 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, as @vstinner wrote in https://bugs.python.org/issue43869#msg391216:
time.time doc says "On Windows and most Unix systems, the epoch is January 1, 1970, 00:00:00 (UTC)"
The epoch doc says "For Unix, the epoch is January 1, 1970, 00:00:00 (UTC)".
At least, the epoch doc can be completed to also mention that it's the same on Windows.
Right, it's consistent with: https://docs.python.org/dev/library/time.html#time.time "On Windows and most Unix systems, the epoch is January 1, 1970, 00:00:00 (UTC) and leap seconds are not counted towards the time in seconds since the epoch." |
The CI failed. I closed/reopend the CI to trigger new CI jobs. Well, it's an old PR, maybe it contains outside CI config. We will see how it goes ;-) |
Please have a look at my follow-up PR #30664. |
https://bugs.python.org/issue43869