gh-78997: AttributeError if loading fails in LibraryLoader.__getattr__

[farfella]

• Issue: raise AttributeError if loading fails in ctypes.LibraryLoader.__getattr__ #78997

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@farfella

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

[github-actions]

This PR is stale because it has been open for 30 days with no activity.

[jacobtylerwalls]

Hi @farfella, thanks for this, do you think you could add a brief test to verify the original use case? I'm not an expert, but I would assume Lib/ctypes/test/test_loader.py would be a reasonable place to start.

[jacobtylerwalls]

Ah, sorry I was referring to an existing file and meant "test_loading.py", not "test_loader.py", my mistake:

cpython/Lib/ctypes/test/test_loading.py

Line 26 in 507ed6f

class LoaderTest(unittest.TestCase):

[farfella]

Thanks for your all your help and feedback, @jacobtylerwalls! :) Hoping style-checks passes this time.

[farfella]

Thanks! Fewer lines of code. :)

[eric-wieser]

Suggested change

	Fix issue where hasattr(ctypes.windll, 'somefunction') raises OSError instead of the expected behavior: returning False
	`hasattr(ctypes.windll, 'nonexistant')` now returns `False` instead of raising `OSError`.

[eric-wieser]

Suggested change

	# This test case verifies that
	# ctypes.LoadLibrary.__getattr__ raises AttributeError
	# when name cannot be resolved
	# bpo-34816: shouldn't raise OSError

[eric-wieser]

LGTM!

[netlify]

✅ Deploy Preview for python-cpython-preview canceled.

Name	Link
🔨 Latest commit	f151341
🔍 Latest deploy log	https://app.netlify.com/sites/python-cpython-preview/deploys/639b9b8d57bbf700082c03c5

[FFY00]

@farfella I am now in a position where I can merge this, could you update the PR to resolve the conflicts?

[bedevere-bot]

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

[cpython-cla-bot]

All commit authors signed the Contributor License Agreement.

[eric-wieser]

@farfella, it looks like you just discarded all your changes...

[farfella]

Yeah.... I saw this "Sync fork" button (that is new to me) for my branch on GitHub web UI and clicked it. This is the consequence.... My local copy still has everything. I'll push that up.

[farfella]

Updated PR to resolve conflicts

[terryjreedy]

force-pushing may be the reason for the review-request spamming. Please use simple update merges. git merge upstream/main last I knew.

[FFY00]

Alright, thank you @farfella for getting this back into shape! Can you just apply the feedback from code-review from @eric-wieser? After that, we can go ahead and merge this 👍

[FFY00]

Thanks @farfella for the fix, and @eric-wieser for the review!

[eli-schwartz]

Minor rebase issue in the test file. :)