Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-71339: Use new assertion methods in test_import and test_importlib #129052

Merged
merged 1 commit into from
Jan 21, 2025
Merged

gh-71339: Use new assertion methods in test_import and test_importlib #129052

merged 1 commit into from
Jan 21, 2025
+51 −54

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 20, 2025 •
edited by bedevere-app bot
Loading

They provide better error report.

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news labels Jan 20, 2025
ncoghlan
ncoghlan approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforward test improvement to me.

@ncoghlan
Copy link
Contributor

I was going to suggest backporting, but these methods are new in 3.14, so that's not an option.

@bedevere-app bedevere-app bot mentioned this pull request Jan 21, 2025
Open
@serhiy-storchaka serhiy-storchaka merged commit f7cc7d2 into python:main Jan 21, 2025
47 checks passed
@serhiy-storchaka serhiy-storchaka deleted the test_importlib-asserts branch January 21, 2025 09:24
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 bugs and security fixes label Jan 21, 2025
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f7cc7d296c2cbb33d3f0bde4ace82e8569f7dbc3 3.13

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jan 21, 2025
@serhiy-storchaka
[3.13] pythongh-71339: Use new assertion methods in test_import and t…
ceaf7f5 
…est_importlib (pythonGH-129052)

(cherry picked from commit f7cc7d2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 21, 2025

GH-129123 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 21, 2025
@serhiy-storchaka
Copy link
Member Author

I was going to suggest backporting, but these methods are new in 3.14, so that's not an option.

It is an option. See #129123.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

@brettcannon brettcannon brettcannon approved these changes

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @ncoghlan @brettcannon