Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-122272: guarantee specifiers %F and %C for datetime.strftime to be 0-padded #122436

Merged

Conversation

blhsing
Copy link
Contributor

@blhsing blhsing commented Jul 30, 2024

@blhsing blhsing marked this pull request as ready for review July 30, 2024 06:08
@blhsing blhsing requested review from pganssle and abalkin as code owners July 30, 2024 06:08
@serhiy-storchaka serhiy-storchaka self-requested a review July 30, 2024 10:54
@erlend-aasland
Copy link
Contributor

I won't be able to review this for at least a couple of weeks.

Lib/_pydatetime.py Outdated Show resolved Hide resolved
Modules/_datetimemodule.c Outdated Show resolved Hide resolved
Lib/_pydatetime.py Outdated Show resolved Hide resolved
Modules/_datetimemodule.c Outdated Show resolved Hide resolved
@mhsmith
Copy link
Member

mhsmith commented Aug 22, 2024

I've restored the previous reviewers list.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 126910e into python:main Aug 23, 2024
38 checks passed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Aug 23, 2024
@miss-islington-app
Copy link

Thanks @blhsing for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @blhsing for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @blhsing and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 126910edba812a01794f307b0cfa2a7f02bda190 3.12

@miss-islington-app
Copy link

Sorry, @blhsing and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 126910edba812a01794f307b0cfa2a7f02bda190 3.13

@serhiy-storchaka serhiy-storchaka removed needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Aug 23, 2024
@serhiy-storchaka serhiy-storchaka removed their assignment Aug 23, 2024
@blhsing blhsing deleted the fix-datetime-strftime-f-c-normalization branch August 23, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants