Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101100: Fix Sphinx nitpicks in library/abc.rst #112703

Merged
merged 1 commit into from
Dec 4, 2023
Merged

gh-101100: Fix Sphinx nitpicks in library/abc.rst #112703

merged 1 commit into from
Dec 4, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Dec 4, 2023 •
edited by github-actions bot
Loading

Also fix some "Alex nitpicks" while we're here:

  • There's no need to link to the module we're already in
  • There's also no need to link to the ABC class when we're already in the definition for the ABC class
  • There's no need to link to the same method/class/attribute/etc. more than once per paragraph.

📚 Documentation preview 📚: https://cpython-previews--112703.org.readthedocs.build/

@AlexWaygood AlexWaygood added skip news needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Dec 4, 2023
@bedevere-app bedevere-app bot mentioned this pull request Dec 4, 2023
Open
hugovk
hugovk approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔤🎈

@AlexWaygood AlexWaygood merged commit 9560e0d into python:main Dec 4, 2023
25 checks passed
@AlexWaygood AlexWaygood deleted the abc-Sphinx-nits branch December 4, 2023 12:42
@miss-islington-app
Copy link

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9560e0d6d7a316341939b4016e47e03bd5bf17c3 3.12

@bedevere-app
Copy link

bedevere-app bot commented Dec 4, 2023

GH-112704 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 4, 2023
@AlexWaygood @miss-islington
pythongh-101100: Fix Sphinx nitpicks in library/abc.rst (pythonGH-1…
0022301 
…12703)

(cherry picked from commit 9560e0d)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 4, 2023
AlexWaygood added a commit that referenced this pull request Dec 4, 2023
@miss-islington @AlexWaygood
[3.11] gh-101100: Fix Sphinx nitpicks in library/abc.rst (GH-112703) (
798d437 
#112704)

gh-101100: Fix Sphinx nitpicks in `library/abc.rst` (GH-112703)
(cherry picked from commit 9560e0d)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 4, 2023

GH-112705 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 4, 2023
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Dec 4, 2023
@AlexWaygood
[3.12] pythongh-101100: Fix Sphinx nitpicks in library/abc.rst (pyt…
02820b7 
…hon#112703)

(cherry-picked from commit 9560e0d)
AlexWaygood added a commit that referenced this pull request Dec 4, 2023
@AlexWaygood
[3.12] gh-101100: Fix Sphinx nitpicks in library/abc.rst (#112703) (#…
f49d073 
…112705)

(cherry-picked from commit 9560e0d)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@AlexWaygood @aisk
pythongh-101100: Fix Sphinx nitpicks in library/abc.rst (python#112703
da78577 
)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AlexWaygood @Glyphack
pythongh-101100: Fix Sphinx nitpicks in library/abc.rst (python#112703
e8ff40d 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees

@AlexWaygood AlexWaygood

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWaygood @hugovk