Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-101100: Docs: Fix references to several numeric dunders #106278

Merged
merged 6 commits into from
Jun 30, 2023

Conversation

koyuki7w
Copy link
Contributor

@koyuki7w koyuki7w commented Jun 30, 2023

__index__, __int__, __float__, __complex__ are documented as methods of object, so prepended ~object to reference correctly.


📚 Documentation preview 📚: https://cpython-previews--106278.org.readthedocs.build/

``__index__``, ``__int__``, ``__float__``, ``__complex__`` are methods
of ``object``, so prepended `~object` to reference correctly.
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits, but looks great overall. Thanks!

Doc/c-api/complex.rst Outdated Show resolved Hide resolved
Doc/c-api/float.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Outdated Show resolved Hide resolved
koyuki7w and others added 3 commits June 30, 2023 23:13
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jun 30, 2023
@AlexWaygood AlexWaygood changed the title gh-101100: Fix references to object methods gh-101100: Docs: Fix references to several numeric dunders Jun 30, 2023
@AlexWaygood AlexWaygood self-assigned this Jun 30, 2023
@AlexWaygood AlexWaygood merged commit a8ae739 into python:main Jun 30, 2023
@miss-islington
Copy link
Contributor

Thanks @F3eQnxN3RriK for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 30, 2023
…honGH-106278)

(cherry picked from commit a8ae739)

Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot
Copy link

GH-106281 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 30, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 30, 2023
…honGH-106278)

(cherry picked from commit a8ae739)

Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot
Copy link

GH-106282 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 30, 2023
AlexWaygood added a commit that referenced this pull request Jun 30, 2023
…-106278) (#106281)

gh-101100: Docs: Fix references to several numeric dunders (GH-106278)
(cherry picked from commit a8ae739)

Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Jun 30, 2023
…-106278) (#106282)

gh-101100: Docs: Fix references to several numeric dunders (GH-106278)
(cherry picked from commit a8ae739)

Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@koyuki7w koyuki7w deleted the doc-patch-2 branch June 30, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants