Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90015: Document that PEP-604 unions do not support forward references #105366

Merged
merged 8 commits into from
Jun 7, 2023
Merged

gh-90015: Document that PEP-604 unions do not support forward references #105366

merged 8 commits into from
Jun 7, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jun 6, 2023 •
edited by github-actions bot
Loading

@AlexWaygood AlexWaygood added topic-typing needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jun 6, 2023
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Jun 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 6, 2023
Closed
AlexWaygood
AlexWaygood commented Jun 6, 2023
View reviewed changes
Doc/library/stdtypes.rst Outdated Show resolved Hide resolved
@AlexWaygood
Copy link
Member Author

Docs preview: https://cpython-previews--105366.org.readthedocs.build/en/105366/library/stdtypes.html#union-type

Fidget-Spinner
Fidget-Spinner reviewed Jun 6, 2023
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for Jelle.

@AlexWaygood AlexWaygood closed this Jun 7, 2023
@AlexWaygood AlexWaygood reopened this Jun 7, 2023
@AlexWaygood AlexWaygood requested a review from JelleZijlstra June 7, 2023 16:31
AlexWaygood
AlexWaygood commented Jun 7, 2023
View reviewed changes
Doc/library/stdtypes.rst Outdated Show resolved Hide resolved
@AlexWaygood AlexWaygood closed this Jun 7, 2023
@AlexWaygood AlexWaygood reopened this Jun 7, 2023
AlexWaygood
AlexWaygood commented Jun 7, 2023
View reviewed changes
Doc/library/stdtypes.rst Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood commented Jun 7, 2023
View reviewed changes
Doc/library/stdtypes.rst Outdated Show resolved Hide resolved
@AlexWaygood AlexWaygood enabled auto-merge (squash) June 7, 2023 17:14
@AlexWaygood AlexWaygood disabled auto-merge June 7, 2023 17:15
@AlexWaygood AlexWaygood merged commit fbdee00 into python:main Jun 7, 2023
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-105460 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 7, 2023
@bedevere-bot
Copy link

GH-105461 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2023
@AlexWaygood @miss-islington
pythongh-90015: Document that PEP-604 unions do not support forward r…
fa573ad 
…eferences (pythonGH-105366)

(cherry picked from commit fbdee00)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2023
@AlexWaygood @miss-islington
pythongh-90015: Document that PEP-604 unions do not support forward r…
74cdc65 
…eferences (pythonGH-105366)

(cherry picked from commit fbdee00)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Jun 7, 2023
@miss-islington @AlexWaygood
[3.11] gh-90015: Document that PEP-604 unions do not support forward …
40d1d28 
…references (GH-105366) (#105461)

gh-90015: Document that PEP-604 unions do not support forward references (GH-105366)
(cherry picked from commit fbdee00)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Jun 7, 2023
@miss-islington @AlexWaygood
[3.12] gh-90015: Document that PEP-604 unions do not support forward …
4eadfb1 
…references (GH-105366) (#105460)

gh-90015: Document that PEP-604 unions do not support forward references (GH-105366)
(cherry picked from commit fbdee00)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexWaygood @miss-islington @bedevere-bot @JelleZijlstra @Fidget-Spinner