Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99955: standardize return values of functions in compiler's code-gen #100010

Merged
merged 96 commits into from
Dec 12, 2022
Merged

gh-99955: standardize return values of functions in compiler's code-gen #100010

merged 96 commits into from
Dec 12, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Dec 5, 2022 •
edited by bedevere-bot
Loading

Consistently return -1 for error, 0 for success.

@iritkatriel
compiler_setup returns SUCCESS/ERROR
97d929f
@iritkatriel
cfg_builder_init returns SUCCESS/ERROR
0e14141
@iritkatriel
compiler_set_qualname returns SUCCESS/ERROR
5d81ad0
@iritkatriel
basicblock_addop returns SUCCESS/ERROR
6d56a1b
@iritkatriel
cfg_builder_addop returns SUCCESS/ERROR
3b87215
@iritkatriel
cfg_builder_addop_noarg returns SUCCESS/ERROR
829ed2d
@iritkatriel
cfg_builder_addop_i returns SUCCESS/ERROR
8be8f0b
@iritkatriel
compiler_addop_name returns SUCCESS/ERROR
9374ac0
@iritkatriel
compiler_addop_o and compiler_addop_load_const returns SUCCESS/ERROR
9d21d49
@iritkatriel
cfg_builder_addop_j returns SUCCESS/ERROR
a67c612
@iritkatriel
prepend macros with _
844b78f
@iritkatriel
add new versions of the macros (not used yet)
4ca4b8c
@iritkatriel
compiler_enter_scope returns SUCCESS/ERROR
9baeb63
@iritkatriel
find_add returns bool
566acc5
@iritkatriel
compiler_push_fblock returns SUCCESS/ERROR
93287a1
@iritkatriel
compiler_call_exit_with_nones returns SUCCESS/ERROR
8515380
@iritkatriel
pop_except_and_reraise returns SUCCESS/ERROR
13583a3
@iritkatriel
compiler_add_yield_from returns SUCCESS/ERROR
1fd574a
@iritkatriel
compiler_unwind_fblock returns SUCCESS/ERROR
a3d5cad
@iritkatriel
compiler_unwind_fblock_stack returns SUCCESS/ERROR
6fe5dd7
@iritkatriel
compiler_body returns SUCCESS/ERROR
297a0d6
@iritkatriel
compiler_codegen returns SUCCESS/ERROR
c504cd3
@iritkatriel
compiler_make_closure returns SUCCESS/ERROR
b6028e2
@iritkatriel
compiler_decorators and compiler_apply_decorators return SUCCESS/ERROR
19235f7
@iritkatriel
compiler_visit_kwonlydefaults returns SUCCESS/ERROR
9d93635
@iritkatriel
forbidden_name returns bool
dfbe826
@iritkatriel
compiler_check_debug_one_arg, compiler_check_debug_args, compiler_che…
9757b0d 
…ck_debug_args_seq return SUCCESS/ERROR
@iritkatriel
insert_instruction, wrap_in_stopiteration_handler return SUCCESS/ERROR
151e8f0
@iritkatriel
compiler_class returns SUCCESS/ERROR
1409c3e
@iritkatriel
compiler_return returns SUCCESS/ERROR
d1a28e4
@bedevere-bot bedevere-bot mentioned this pull request Dec 5, 2022
Closed
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 5, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 730f5fd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 5, 2022
markshannon
markshannon reviewed Dec 12, 2022
View reviewed changes
Python/compile.c Outdated Show resolved Hide resolved
@markshannon markshannon self-requested a review December 12, 2022 10:14
markshannon
markshannon approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. This makes the code so much easier to follow and maintain.

@markshannon
Copy link
Member

Actually, it is probably best to add a news item, so anyone familiar with the code knows about the change.

@netlify
Copy link

netlify bot commented Dec 12, 2022 •
edited
Loading

✅ Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit a47b482
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6397275b1af5c3000881e0e0

iritkatriel
iritkatriel commented Dec 12, 2022
View reviewed changes
Python/compile.c Outdated Show resolved Hide resolved
iritkatriel
iritkatriel commented Dec 12, 2022
View reviewed changes
Python/compile.c Outdated Show resolved Hide resolved
@iritkatriel iritkatriel merged commit e4ea33b into python:main Dec 12, 2022
@sobolevn sobolevn mentioned this pull request Dec 13, 2022
Closed
carljm added a commit to carljm/cpython that referenced this pull request Dec 14, 2022
@carljm
Merge branch 'main' into typedocs
53d33a1 
* main: (103 commits)
  pythongh-100248: Add missing `ssl_shutdown_timeout` parameter in `asyncio` docs (python#100249)
  Assorted minor fixes for specialization stats. (pythonGH-100219)
  pythongh-100176: venv: Remove redundant compat code for Python <= 3.2 (python#100177)
  pythonGH-100222: Redefine _Py_CODEUNIT as a union to clarify structure of code unit. (pythonGH-100223)
  pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) (python#100215)
  pythonGH-100206: use versionadded for the addition of sysconfig.get_default_scheme (python#100207)
  pythongh-81057: Move _Py_RefTotal to the "Ignored Globals" List (pythongh-100203)
  pythongh-81057: Move Signal-Related Globals to _PyRuntimeState (pythongh-100085)
  pythongh-81057: Move faulthandler Globals to _PyRuntimeState (pythongh-100152)
  pythongh-81057: Move tracemalloc Globals to _PyRuntimeState (pythongh-100151)
  pythonGH-100143: Improve collecting pystats for parts of runs (pythonGH-100144)
  pythongh-99955: standardize return values of functions in compiler's code-gen (python#100010)
  pythongh-79218: Define `MS_WIN64` macro for Mingw-w64 64bit on Windows (pythonGH-100137)
  Fix: typo (Indention) (pythonGH-99904)
  pythongh-96715 Remove redundant NULL check in `profile_trampoline` function (python#96716)
  pythongh-100176: remove incorrect version compatibility check from argument clinic (python#100190)
  clarify the 4300-digit limit on int-str conversion (python#100175)
  pythongh-70393: Clarify mention of "middle" scope (python#98839)
  pythongh-99688: Fix outdated tests in test_unary (python#99712)
  pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178)
  ...
@carljm carljm mentioned this pull request Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iritkatriel @bedevere-bot @markshannon