Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure is checking for ttyname but code is using ttyname_r #127614

Closed
glebm opened this issue Dec 4, 2024 · 3 comments · Fixed by #128503
Closed

configure is checking for ttyname but code is using ttyname_r #127614

glebm opened this issue Dec 4, 2024 · 3 comments · Fixed by #128503
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@glebm
Copy link

glebm commented Dec 4, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

PR #14868 by @chibby0ne changed the code to use ttyname_r but the configure script is checking for ttyname.

There are some old systems, such as OSX Tiger, that don't have ttyname_r (at least not by default), so it'd be nice if ttyname_r was checked for separately with fallback to ttyname.

CPython versions tested on:

3.11, 3.12

Operating systems tested on:

macOS

Linked PRs
@glebm glebm added the type-bug An unexpected behavior, bug, or error label Dec 4, 2024
@glebm glebm mentioned this issue Dec 4, 2024
Merged
12 tasks
glebm added a commit to glebm/macports-ports that referenced this issue Dec 4, 2024
@glebm
python39+: fix build on Tiger
2e66f5c 
Upstream issue: python/cpython#127614
glebm added a commit to glebm/macports-ports that referenced this issue Dec 4, 2024
@glebm
python39+: fix build on Tiger
6aab3cd 
Upstream issue python/cpython#127614
glebm added a commit to glebm/macports-ports that referenced this issue Dec 4, 2024
@glebm
python39+: fix build on Tiger
ca9071d 
Upstream issue python/cpython#127614
glebm added a commit to glebm/macports-ports that referenced this issue Dec 5, 2024
@glebm
python39+: fix build on Tiger
009bfc7 
Upstream issue python/cpython#127614
@picnixz picnixz added the build The build process and cross-build label Dec 5, 2024
glebm added a commit to glebm/macports-ports that referenced this issue Dec 6, 2024
@glebm
python39+: fix build on Tiger
14823fc 
Upstream issue python/cpython#127614
glebm added a commit to glebm/macports-ports that referenced this issue Dec 6, 2024
@glebm
python39+: fix build on tiger gcc14
318232f 
Upstream issue python/cpython#127614
jmroot pushed a commit to macports/macports-ports that referenced this issue Dec 7, 2024
@glebm @jmroot
python39+: fix build on tiger gcc14
a6870ef 
Upstream issue python/cpython#127614
@erlend-aasland
Copy link
Contributor

Mac OS X Tiger is not supported; I'm not sure it is worth it to add a fallback to ttyname. I agree, though, that we should fix the build dependency check.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jan 4, 2025
@erlend-aasland
pythongh-127614: Correctly check for ttyname_r() in configure
f25911a 
PR python#14868 replaced the ttyname() call with ttyname_r(), but the old
check remained.
@bedevere-app bedevere-app bot mentioned this issue Jan 4, 2025
Merged
@erlend-aasland erlend-aasland linked a pull request Jan 4, 2025 that will close this issue
gh-127614: Correctly check for ttyname_r() in configure #128503
Merged
erlend-aasland added a commit that referenced this issue Jan 7, 2025
@erlend-aasland
gh-127614: Correctly check for ttyname_r() in configure (#128503)
e08b282 
PR #14868 replaced the ttyname() call with ttyname_r(), but the old
check remained.
@bedevere-app bedevere-app bot mentioned this issue Jan 7, 2025
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jan 7, 2025
@erlend-aasland
[3.13] pythongh-127614: Correctly check for ttyname_r() in configure (p…
cf1909a 
…ython#128503)

(cherry picked from commit e08b282)

PR python#14868 replaced the ttyname() call with ttyname_r(), but the old
check remained.
@bedevere-app bedevere-app bot mentioned this issue Jan 7, 2025
Merged
@erlend-aasland
Copy link
Contributor

Thanks for the report, @glebm

erlend-aasland added a commit that referenced this issue Jan 7, 2025
@erlend-aasland
[3.12] gh-127614: Correctly check for ttyname_r() in configure (#128503…
6b33719 
…) (#128599)

(cherry picked from commit e08b282)

PR #14868 replaced the ttyname() call with ttyname_r(), but the old
check remained.
@glebm
Copy link
Author

glebm commented Jan 7, 2025

Thanks for the fix!

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@erlend-aasland @srinivasreddy
pythongh-127614: Correctly check for ttyname_r() in configure (python…
ebc1cc2 
…#128503)

PR python#14868 replaced the ttyname() call with ttyname_r(), but the old
check remained.
erlend-aasland added a commit that referenced this issue Jan 11, 2025
@erlend-aasland
[3.13] gh-127614: Correctly check for ttyname_r() in configure (#128503…
436064a 
…) (#128598)

(cherry picked from commit e08b282)

PR #14868 replaced the ttyname() call with ttyname_r(), but the old
check remained.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-127614: Correctly check for ttyname_r() in configure erlend-aasland/cpython
3 participants
@glebm @picnixz @erlend-aasland