-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use actual precise Python version @ coverage flags #507
Conversation
Codecov Report
@@ Coverage Diff @@
## main #507 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1828 1828
Branches 223 211 -12
=========================================
Hits 1828 1828
Flags with carried forward coverage won't be shown. Click here to find out more. |
This change creates duplicated entries in the table included in the previous message, with the On codecov only the actual versions are included. |
Looks like that comment includes historic flags that existed before this PR, showing that this PR's workflow jobs didn't report anything with those flags. I'm going to guess that it compares what changed vs |
So (for example) Do we actually care about the patch version in the coverage history? That is, when checking the coverage, do we want continuous history across all 3.9 versions or does it not matter? |
I think this may be an important bit of information. Especially, if there's some conditional behavior/hacks that are only triggered on some patch versions. This might prove useful in future archeology while debugging stuff. |
Fair enough! I suppose we could even send x.y and x.y.z flags, but will leave it up to you. |
There's no easy way to infer that x.y version without resorting to an extra task. This is because the matrix values aren't always suitable for flags. |
The matrix factor for the Python version is imprecise and doesn't always contain characters suitable for Codecov flags.
actions/setup-python@v4
now provides an output specifying exactly what's been installed based on the request. This value is perfect for use in flags. This patch implements just that.