-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
info: fix metadata build error propagation #9870
Conversation
e62c95a
to
c305c6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Have you thought about adding the indentation of the inner error and/or the listing of possible reasons also at
poetry/src/poetry/installation/executor.py
Lines 316 to 322 in c70cbf4
"<info>" | |
"Note: This error originates from the build backend," | |
" and is likely not a problem with poetry" | |
f" but with {pkg.pretty_name} ({pkg.full_pretty_version})" | |
" not supporting PEP 517 builds. You can verify this by" | |
f" running '{pip_command} \"{requirement}\"'." | |
"</info>" |
Yeah. But figured I'll do that in a separate PR just to keep things clean here. I also wanted to see if we can unify that somehow. Once this is accepted I can work on that, ie. No one has objections to the formatting. |
@radoering @Secrus I have now also unified the changes for executor and info as well here. |
b9518af
to
5c825e1
Compare
140130c
to
b27ea61
Compare
b27ea61
to
ca4ceb1
Compare
ca4ceb1
to
6b0d0f6
Compare
This change fixes a regression that caused the swallowing of PEP517 build errors when isolated builds fail during metadata build.
6b0d0f6
to
f308e32
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This change fixes a regression that caused the swallowing of PEP517 build errors when isolated builds fail during metadata build.
Borrowing from another issue, you can use the following
pyproject.toml
to reproduce/test.Output w/ Poetry (1.8.4)
Output w/ Poetry (git@main)
Output w/ PR
You can test this pull request using the following command. You can swap podman with docker if you use that.
You can also preview the changes on asciinema.