Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint: run more flake8-pytest-style #8309

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Aug 16, 2024

Expand from PT006 to all of PT:

https://docs.astral.sh/ruff/rules/#flake8-pytest-style-pt

Fix warnings for PT001, PT014 and PT018.

Exclude these which have warnings:

  • PT007 pytest-parametrize-values-wrong-type
  • PT011 pytest-raises-too-broad
  • PT012 pytest-raises-with-multiple-statements
  • PT016 pytest-fail-without-message
  • PT017 pytest-assert-in-except

I'm fine if someone wants to tackle those in another PR.

@hugovk hugovk added the Testing label Aug 16, 2024
@hugovk hugovk force-pushed the flake8-pytest-style branch from ee134d1 to 5747267 Compare August 17, 2024 08:46
@hugovk
Copy link
Member Author

hugovk commented Aug 17, 2024

Changed my mind about PT001, let's skip it.

@radarhere radarhere merged commit 27ca30d into python-pillow:main Aug 19, 2024
49 of 50 checks passed
@hugovk hugovk deleted the flake8-pytest-style branch August 19, 2024 11:38
@radarhere radarhere mentioned this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants