-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix APNG info after seeking backwards more than twice #7701
Conversation
…g to the first frame multiple times.
Please could you add a test for this? |
…o the first frame multiple times.
@hugovk I'm guessing the codecov failure is because the github actions aren't approved to run and the appveyor builds don't emit coverage in the src directory. |
I approved the GitHub Actions run and CodeCov is no longer failing. |
Tests/test_file_apng.py
Outdated
def test_apng_issue_7700(): | ||
# /~https://github.com/python-pillow/Pillow/issues/7700 | ||
with Image.open("Tests/images/apng/issue_7700.png") as im: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you give the test and image more descriptive names than issue_7700
?
Is an occasional segfault in testing a known issue? I'm guessing the reason for the failing action is not related to this PR. |
Someone has triggered it to re-run so I can't see which job failed, but yes, the PyPy jobs occasionally segfault while collecting tests. |
I triggered the rerun. It was /~https://github.com/python-pillow/Pillow/actions/runs/7452748291/job/20281343444 that failed. |
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
Thank you! |
Fixes #7700