Ensure that furthest v is set in quantize2 #6256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, in
quantize2
, the variablePixel furthest
is only used for itsv
property. So thePixel
can be simplified to just thatuint32_t
.Second,
quantize2
setsfurthestDistance
to zero,Pillow/src/libImaging/Quant.c
Lines 1579 to 1583 in 31800a0
and then runs
compute_distances
, assigningfurthest
,Pillow/src/libImaging/Quant.c
Lines 1528 to 1541 in 31800a0
before it returns to
quantize2
andp[i].v
anddata.new.v
are set todata.furthest.v
.What if
oldDist
was never greater than zero though? Thenfurthest.v
would never be assigned.This causes a problem in python-pillow/docker-images#148 - /~https://github.com/python-pillow/docker-images/runs/6247349541?check_suite_focus=true.
So instead, this PR sets it to the first
v
ofpixelData
.