Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PEP 691 config to banderx #1161

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Add PEP 691 config to banderx #1161

merged 3 commits into from
Aug 1, 2022

Conversation

cooperlees
Copy link
Contributor

banderx is an example way to serve a filesystem bandersnatch.
This PR adds an example to respect PEP691 clients.

  • Updated README.md
  • Added a README.md to banderx dir to explain how to build + start

Test: Ran the container and ensured nginx did not error and returned via curl

banderx is an example way to serve a filesystem bandersnatch.
This PR adds an example to respect PEP691 clients.

- Updated README.md
- Added a README.md to banderx dir to explain how to build + start

Test: Ran the container and ensured nginx did not error and returned via `curl`
@cooperlees cooperlees added the enhancement New feature or request label Jul 31, 2022
@cooperlees cooperlees requested a review from dstufft July 31, 2022 15:24
@cooperlees cooperlees added skip news Skip CI check for news/changelog and removed skip news Skip CI check for news/changelog labels Jul 31, 2022
@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #1161 (ece3e5d) into main (c9e6d8d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1161   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          31       31           
  Lines        4218     4218           
  Branches      662      662           
=======================================
  Hits         3517     3517           
  Misses        523      523           
  Partials      178      178           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9e6d8d...ece3e5d. Read the comment docs.

@cooperlees
Copy link
Contributor Author

cooperlees commented Jul 31, 2022

Really need to fix this code coverage bot or remove it. It's annoying always getting this email for diffs that don't change any code :(

@cooperlees cooperlees merged commit 75fa020 into main Aug 1, 2022
@cooperlees cooperlees deleted the banderx_691 branch August 1, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant