Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64-bit ARM Linux wheels #42

Closed
taleinat opened this issue Jan 13, 2023 · 7 comments
Closed

64-bit ARM Linux wheels #42

taleinat opened this issue Jan 13, 2023 · 7 comments

Comments

@taleinat
Copy link

taleinat commented Jan 13, 2023

Would it be possible to provide binary wheels for 64-bit ARM (a.k.a. "aarch64") Linux?

I see that such wheels are already provided for 64-bit ARM macOS and x86-64 Linux, so hopefully not too difficult to do...

@mrbean-bremen
Copy link
Member

I don't have experience in that area, but there seems to be no linux arm64 runner in GH actions yet, so it can't just be added to the build matrix.
There is an action that gives the possibility to run arm64 on an emulated system that may be used for this, as far as I understand.
I may have a closer look at this over the weekend, though I would prefer if somebody with access to arm64 linux would try this.

@taleinat
Copy link
Author

taleinat commented Jan 15, 2023

python-gdcm recently implemented this, experimentally, but it seems to work nicely. Perhaps a similar method can be used? Here are the relevant commits.

@mrbean-bremen
Copy link
Member

Thanks - that looks quite helpful! I will probably try this later today.

mrbean-bremen added a commit to mrbean-bremen/pylibjpeg-libjpeg that referenced this issue Jan 15, 2023
- taken from python-gdcm
- see pydicom#42
mrbean-bremen added a commit that referenced this issue Jan 15, 2023
- taken from python-gdcm
- see #42
@mrbean-bremen
Copy link
Member

I made a new patch release with the aarch64 wheels - please check if these work for you.

@mrbean-bremen
Copy link
Member

While I added this I noticed that there are still manylinux-2010 wheels are created both in this project and in pylibjpeg-openjpeg. As far as I understand, they are no longer needed as all target platforms are unsupported and can be removed. Is there anything I'm missing here?

@mrbean-bremen
Copy link
Member

Closing this also as done, please reopen if there are problems.

@taleinat
Copy link
Author

Many thanks @mrbean-bremen! I hope to test these later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants