Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add not supported SSL_ST_* into _all_, fixies #738 #739

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

onovy
Copy link
Contributor

@onovy onovy commented Mar 1, 2018

Without this patch this fails:

from OpenSSL.SSL import *
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python2.7/dist-packages/cryptography/utils.py", line 124, in getattr
obj = getattr(self._module, attr)
AttributeError: 'module' object has no attribute 'SSL_ST_INIT'

Without this patch this fails:
>>> from OpenSSL.SSL import *
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python2.7/dist-packages/cryptography/utils.py", line 124, in __getattr__
    obj = getattr(self._module, attr)
AttributeError: 'module' object has no attribute 'SSL_ST_INIT'
@onovy onovy changed the title Don't add not supported SSL_ST_* into _all_, fixies 738 Don't add not supported SSL_ST_* into _all_, fixies #738 Mar 1, 2018
@codecov
Copy link

codecov bot commented Mar 1, 2018

Codecov Report

Merging #739 into master will decrease coverage by 2.78%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
- Coverage   97.05%   94.27%   -2.79%     
==========================================
  Files          18       17       -1     
  Lines        5711     5711              
  Branches      395      391       -4     
==========================================
- Hits         5543     5384     -159     
- Misses        112      262     +150     
- Partials       56       65       +9
Impacted Files Coverage Δ
src/OpenSSL/SSL.py 89.8% <100%> (-5.15%) ⬇️
src/OpenSSL/_util.py 81.13% <0%> (-9.44%) ⬇️
tests/test_ssl.py 93.76% <0%> (-5.36%) ⬇️
tests/util.py 93.44% <0%> (-3.28%) ⬇️
src/OpenSSL/crypto.py 96.25% <0%> (-0.61%) ⬇️
tests/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d072cae...fe804a8. Read the comment docs.

@alex alex merged commit 993c4e4 into pyca:master Mar 1, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants